Skip to content

Move leeway vet to validate #12999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Move leeway vet to validate #12999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .werft/jobs/build/build-and-publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) {
exec(
`LICENCE_HEADER_CHECK_ONLY=true leeway run components:update-license-header || { echo "[build|FAIL] There are some license headers missing. Please run 'leeway run components:update-license-header'."; exit 1; }`,
);
exec(`leeway vet --ignore-warnings`);

exec(
`leeway build --docker-build-options network=host --werft=true -c remote ${
dontTest ? "--dont-test" : ""
Expand Down
19 changes: 18 additions & 1 deletion .werft/jobs/build/validate-changes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ import { JobConfig } from "./job-config";
export async function validateChanges(werft: Werft, config: JobConfig) {
werft.phase("validate-changes", "validating changes");
try {
await Promise.all([branchNameCheck(werft, config), preCommitCheck(werft), typecheckWerftJobs(werft)]);
await Promise.all([
branchNameCheck(werft, config),
preCommitCheck(werft),
typecheckWerftJobs(werft),
leewayVet(werft),
]);
} catch (err) {
werft.fail("validate-changes", err);
}
Expand Down Expand Up @@ -60,3 +65,15 @@ export async function typecheckWerftJobs(werft: Werft) {
}
werft.done(slice);
}

export async function leewayVet(werft: Werft) {
const slice = "leeway vet --ignore-warnings"
try {
werft.log(slice, "Running leeway vet")
await exec(`leeway vet --ignore-warnings`, {slice, async: true});
werft.log(slice, "leeway vet successful")
} catch (e) {
werft.fail(slice, e)
}
werft.done(slice);
}