Skip to content

[usage] Fix stripe invoice finalization #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2022
Merged

[usage] Fix stripe invoice finalization #13039

merged 1 commit into from
Sep 16, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 16, 2022 •
edited
Loading

Description

We were doing 2 things wrong:

  1. Expanding the wrong response property
  2. Using the Subscription to get the Attribution ID when we needed the Customer

Both fixed here.

Related Issue(s)

Fixes #13035

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@easyCZ easyCZ requested a review from a team September 16, 2022 12:18
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 16, 2022
@easyCZ easyCZ force-pushed the mp/usage-fix-stripe-invoice-get branch from d65eed8 to d41b131 Compare September 16, 2022 12:19
@roboquat roboquat merged commit 686963b into main Sep 16, 2022
@roboquat roboquat deleted the mp/usage-fix-stripe-invoice-get branch September 16, 2022 12:37
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FinalizeInvoice fails with "this property cannot be expanded"
3 participants
@easyCZ @svenefftinge @roboquat