[usage] remove unused GetUpcomingInvoice #13063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
reviewed
Sep 19, 2022
There was a problem hiding this comment.
There are existing calls to this service, I believe we can only remove once there are no more calls to this service (and in different chagesets).
In an incident on Friday September 16, 2022, we've had to patch version of server. Had we removed the implementation of SetBilledInstance in the same changeset, server would now fail on starting workspaces. The same applies here, we need to remove all usage before we land the removal.
|
I have removed the call site in #12997 on Friday. /hold |
easyCZ
approved these changes
Sep 19, 2022
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes no longer needed
getUpcomingInvoiceAPI.Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options: