[server] fix GitHub Education API call #13082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-alex-fetching-the-github-education-12203.1 because the annotations in the pull request description changed |
AlexTugarev
force-pushed
the
alex/fetching-the-github-education-12203
branch
from
9712348 to
d745f7f
Compare
|
started the job as gitpod-build-alex-fetching-the-github-education-12203.4 because the annotations in the pull request description changed |
AlexTugarev
commented
Sep 19, 2022
| @@ -94,8 +94,9 @@ export class EligibilityService { | |||
| logCtx, | |||
| `fetching the GitHub Education API failed with status ${rawResponse.status}: ${rawResponse.statusText}`, | |||
| ); | |||
| return { student: false, faculty: false }; | |||
There was a problem hiding this comment.
adding the missing return avoids running into parse error.
svenefftinge
approved these changes
Sep 19, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes parse errors when the GH Edu API call errors.
Related Issue(s)
Fixes #12203
How to test
Release Notes
Documentation
Werft options:
Valid options are
all,workspace,webapp,ide