Skip to content

[usage] Remove rounding of credits in UI #13172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Sep 21, 2022

Description

Removes rounding of credits. We only store 2 decimal points, so we know that the total will also have at most 2 digits. That's okay to show in the UI.

Related Issue(s)

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested a review from a team September 21, 2022 12:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 21, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-usage-no-rounding.1 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/usage-no-rounding branch from 248b93c to 1492a8a Compare September 21, 2022 12:40
@easyCZ easyCZ force-pushed the mp/usage-no-rounding branch from 1492a8a to 66f6c9e Compare September 21, 2022 12:40
@roboquat roboquat merged commit ae24fc5 into main Sep 21, 2022
@roboquat roboquat deleted the mp/usage-no-rounding branch September 21, 2022 12:58
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Off-by-one difference between total usage and usage detail in usage list
3 participants