[installer] Refactor envvars before release #13174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/installer-env-refactor
branch
from
dad721b to
65cbf3b
Compare
|
/hold |
github-actions
bot
added
the
team: delivery
mrsimonemms
suggested changes
Sep 22, 2022
There was a problem hiding this comment.
I've rebased this from main and there are no conflicts from #13168 - if you can rebase this yourself then I can do the approval
Missing references:
- There are 5 references to
REG_envvars ininstall/installer/scripts/kots-install.shwhich need updating as well REG_DOCKER_CONFIG_JSONininstall/kots/manifests/gitpod-installer-job.yaml
/hold
Pothulapati
force-pushed
the
tar/installer-env-refactor
branch
from
65cbf3b to
1e19128
Compare
mrsimonemms
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
As this change the installer image (the kots-install.sh file), you also need to update the image parameter in both the gitpod-installer-job.yaml and gitpod-installation-status.yaml files to eu.gcr.io/gitpod-core-dev/build/installer:tar-installer-env-refactor.2
I've tested it with that image and works fine so happy to approve and hold - you can remove when updated
/hold
This PR does a cleanup on the environment variables as now they are kind-off a public contract, which means its better to be verbose and meaningful as possible. Once the release is done, it would be harder to do the same. This has the following changes: - Rename `REG` prefix to `REGISTRY` - Change `REG_INCLUSTER_STORAGE_S3_BUCKETNAME `to `REGISTRY_INCLUSTER_STORAGE_S3_BUCKET_NAME` - Change `COMPONENT_PROXY_SERVICE_SERVICETYPE` to `COMPONENT_PROXY_SERVICE_TYPE` Signed-off-by: Tarun Pothulapati <[email protected]>
Pothulapati
force-pushed
the
tar/installer-env-refactor
branch
from
1e19128 to
b7d7352
Compare
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a cleanup on the environment variables as now they are kind-off a public contract, which
means its better to be verbose and meaningful as possible. Once the release is done, it would be harder to do the same.
This has the following changes:
REGprefix toREGISTRYREG_INCLUSTER_STORAGE_S3_BUCKETNAMEtoREGISTRY_INCLUSTER_STORAGE_S3_BUCKET_NAMECOMPONENT_PROXY_SERVICE_SERVICETYPEtoCOMPONENT_PROXY_SERVICE_TYPESigned-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #13151
How to test
Release Notes
Documentation
Werft options:
Valid options are
all,workspace,webapp,ide