Skip to content

[installer-tests] avoid cleaning up preview setup for release branches #13183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

During the upcoming release, we are changing the process to have preview setups with the latest version up for the whole week or until explicitly cleaned up. This is a temporary solution that avoids cleaning up of resources, if the terraform state(or the subdomain) starts with a release- prefix.

Related Issue(s)

Fixes #

How to test

Try running the following:

werft run github -j .werft/k3s-installer-tests.yaml -a subdomain=release-tests-abc -a preview=true

you will see that the setup do not get cleaned up after 10 hours.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@nandajavarma nandajavarma requested a review from a team September 21, 2022 15:27
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 21, 2022
Copy link
Contributor

@mrsimonemms mrsimonemms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

One question. Happy for you to change/ignore then unhold as you see fit

Co-authored-by: Simon Emms <[email protected]>
@nandajavarma
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 75c0594 into main Sep 23, 2022
@roboquat roboquat deleted the nvn/avoid-cleanup branch September 23, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants