Skip to content

Previews: Add required flag to install monitoring-satellite #13216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

ArthurSens
Copy link
Contributor

Description

In preparation for gitpod-io/observability#326, this PR adds the required flag to install monitoring-satellite

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/5207

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@ArthurSens
Copy link
Contributor Author

/hold because merge needs some coordination

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you can merge when you're ready

@ArthurSens
Copy link
Contributor Author

ArthurSens commented Sep 23, 2022

/werft run with-preview

👍 started the job as gitpod-build-as-installer-app-flag.1
(with .werft/ from main)

@ArthurSens
Copy link
Contributor Author

/unhold

observability installer succesfully in https://werft.gitpod-dev.com/job/gitpod-build-as-installer-app-flag.1 :)

@roboquat roboquat merged commit 3350f38 into main Sep 23, 2022
@roboquat roboquat deleted the as/installer-app-flag branch September 23, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants