Skip to content

Cleanup after #13093 #13240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Cleanup after #13093 #13240

merged 1 commit into from
Sep 23, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 23, 2022

Description

Removes reference to install/preview:docker build target

Related Issue(s)

Context: previous PR removing said target: #13093

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@geropl geropl requested a review from a team September 23, 2022 12:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 23, 2022
@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 23, 2022

@geropl added hold because if we remove it from that list I don't think we'll ever build the package. Is this urgent or something we can chat about Monday?

@geropl
Copy link
Member Author

geropl commented Sep 23, 2022

/unhold

@mads-hartmann Package was removed here, I'm just removing the reference so leeway works again 👍

@roboquat roboquat merged commit 1b5e71c into main Sep 23, 2022
@roboquat roboquat deleted the gpl/preview-cleanup branch September 23, 2022 13:31
@mads-hartmann
Copy link
Contributor

@geropl the package wasn't removed it was turned into a dynamic package

@geropl
Copy link
Member Author

geropl commented Sep 23, 2022

@mads-hartmann Ah-a! Sorry for not reading up on that context. 🙇 But also, hearing about "dynamic packages" the first time 😕
My problem was that I wanted to run yarn watch (which is: leeway exec --package .:app --transitive-dependencies --filter-type yarn --components --parallel -- yarn build -w --preserveWatchOutput) and that failed with "cannot find package" (or similar). Do we want to sync somewhere else (Slack)?

@mads-hartmann
Copy link
Contributor

mads-hartmann commented Sep 23, 2022

@geropl Let's chat Monday (I have one foot out the door ☺️) and find a way to add the component back to the top level without breaking things - I thought I had tested the different use-cases but seems I overlooked some ☺️

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants