Skip to content

[installer-tests] fix the subdomain for upgrade tests to include cloud #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2022
Merged

[installer-tests] fix the subdomain for upgrade tests to include cloud #13250

merged 1 commit into from
Sep 25, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

I introduced a regression earlier today, by which the terraform state names didn't include the cloud provider name. This PR fixes this

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@nandajavarma nandajavarma requested a review from a team September 23, 2022 15:46
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 23, 2022
adrienthebo
adrienthebo approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable, but CI is failing due to replicated errors.

/hold for successful CI run, preemptively approving

@roboquat roboquat added size/S and removed size/XS labels Sep 23, 2022
@nandajavarma
Copy link
Contributor Author

/unhold

@nandajavarma
Copy link
Contributor Author

Rebasing with main and testing this!

@nandajavarma nandajavarma force-pushed the nvn/fix-subdomain branch 3 times, most recently from c4543a3 to d5b9a99 Compare September 25, 2022 13:29
@nandajavarma
Copy link
Contributor Author

Upon multiple runs of this, I caught an issue with preflights happening in EKS cluster. Looks like reducing the AWSS3FullAccess access on IAM users used for storage in AWS is failing the preflights. I have an issue open for this here, which could potentially be a blocker for the release. I have added this as a potential blocker for the release.

In the meantime, /unhold

@roboquat roboquat merged commit 6faf8a9 into main Sep 25, 2022
@roboquat roboquat deleted the nvn/fix-subdomain branch September 25, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrienthebo adrienthebo adrienthebo approved these changes

Assignees
No one assigned
Labels
release-note-none size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nandajavarma @adrienthebo @roboquat