[server] mark prebuild as failed when image build fails #13296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-at-imagebuild-fails-prebuild.1 because the annotations in the pull request description changed |
easyCZ
approved these changes
Sep 26, 2022
roboquat
added
deployed: webapp
|
Thanks @AlexTugarev - this is a nice prebuild improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, if an image build started for a prebuild errored, e.g. due to issues with the .Dockerfile, it would mark the workspace instance as stopped, but leave the prebuild workspace entry in "PENDING" state. That causes the UI to remain in same state, which is worsened by the fact that image build logs are not persisted.
This PR adds the missing update to the prebuild workspace entry, which will produce UI state updates as well.
Related Issue(s)
Fixes #13207
How to test
Try with prebuilds for a repo with .Dockerfile build and simple errors in it, e.g.
apt-get install NOT-FOUND, see the prebuilds is rendered as failed and does not remain in PENDING state.Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide