Skip to content

[db-sync] Remove duplicate entry for d_b_prebuilt_workspace #13306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Remove a duplicate entry for the d_b_prebuilt_workspace table from the db-sync config.

The removed entry is the same as the remaining one but lacked the deletionColumn definition.

Looking at the EU failover we have many entries in d_b_prebuilt_workspace for which deleted = 1, which would indicate that only the entry without the deletionColumn was ever respected. Merging this will therefore delete those records permanently.

Related Issue(s)

Relates to #9198

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@andrew-farries andrew-farries requested a review from a team September 26, 2022 11:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Sep 26, 2022
@andrew-farries
Copy link
Contributor Author

/hold

@andrew-farries
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 9cc9c35 into main Sep 26, 2022
@roboquat roboquat deleted the af/remove-duplication-from-db-sync-config branch September 26, 2022 12:16
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants