Skip to content

[installer-tests] fix cluster-issuer install test condition #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

nandajavarma
Copy link
Contributor

Description

Currently cluster-issuer is not getting installed in test setups due to wrong condition on a Makefile. This PR fixes that issue

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@nandajavarma nandajavarma requested a review from a team September 26, 2022 16:20
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Sep 26, 2022
@nandajavarma
Copy link
Contributor Author

nandajavarma commented Sep 26, 2022

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nandajavarma
Copy link
Contributor Author

worked!! https://werft.gitpod-dev.com/job/gitpod-custom-nvn-fix-issuer.1 🥳

@nandajavarma
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 85f30d9 into main Sep 26, 2022
@roboquat roboquat deleted the nvn/fix-issuer branch September 26, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XS team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants