[public-api] Implement connection pool with LRU cache #13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
easyCZ
changed the title
9 tasks
easyCZ
force-pushed
the
mp/public-api-caching-proxy
branch
2 times, most recently
from
68b09d4 to
f82ebaf
Compare
easyCZ
changed the title
4 tasks
easyCZ
force-pushed
the
mp/public-api-caching-proxy
branch
from
f82ebaf to
1826f37
Compare
|
/hold for dependency on #14171 |
easyCZ
force-pushed
the
mp/public-api-caching-proxy
branch
from
1826f37 to
ba16a80
Compare
|
/unhold dependency satisfied |
|
/unhold |
andrew-farries
suggested changes
Oct 31, 2022
easyCZ
force-pushed
the
mp/public-api-caching-proxy
branch
from
ba16a80 to
8776057
Compare
andrew-farries
approved these changes
Oct 31, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a connection pool implementation for
ServerConnectionPool. This pool caches connections by their token. The cache is an LRU.Initially, the LRU size is set to 3k which is derived from existing WS connection count on server.
There are metrics to track the cache hit rate, as well as how full the cache is.
Related Issue(s)
How to test
Unit test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide