Skip to content

Skip "MountVolume.MountDevice failed for volume" #13760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Oct 11, 2022

Description

Ignore the FailedMount event with the message contains MountVolume.MountDevice failed for volume.

The ws-manager catches the FailedMount event and writes the error message into the workspace Conditions.Failed.
Then the workspace pod is stopped, and the workspace failed message will be shown to the user.

Related Issue(s)

Fixes #13353

How to test

Run the loadgen with PVC over 100 regular workspaces.
Watch the events FailedMount happens but the workspace pod turns into Running state.

Release Notes

None

Documentation

None

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13353.5 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13353.6 because the annotations in the pull request description changed
(with .werft/ from main)

@jenting jenting marked this pull request as ready for review October 11, 2022 12:42
@jenting jenting requested a review from a team October 11, 2022 12:42
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 11, 2022
@easyCZ
Copy link
Member

easyCZ commented Oct 11, 2022

/hold due to failing build and blocking merge Q, feel free to unblock once CI passes

@jenting
Copy link
Contributor Author

jenting commented Oct 11, 2022

/werft run

👍 started the job as gitpod-build-jenting-13353.8
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jenting-13353.7 because the annotations in the pull request description changed
(with .werft/ from main)

@kylos101
Copy link
Contributor

@jenting if you need help to get build and tests passing, please reach out to @utam0k .

Ignore the FailedMount event with the message contains MountVolume.MountDevice failed for volume.

The ws-manager catches the FailedMount event and writes the error message into the workspace Conditions.Failed.
Then, the workspace pod is stopped, and the workspace failed message will be shown to the user.

Signed-off-by: JenTing Hsiao <[email protected]>
@jenting
Copy link
Contributor Author

jenting commented Oct 12, 2022

/unhold

@roboquat roboquat merged commit 801de49 into main Oct 12, 2022
@roboquat roboquat deleted the jenting/13353 branch October 12, 2022 00:44
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PVC] loadgen testing Pod can't mount Volume
5 participants