Skip to content

ws-manager: NODE_EXTRA_CA_CERTS is the value of the gitpod internals #13821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Oct 13, 2022

Description

NODE_EXTRA_CA_CERTS is a variable used inside gitpod, but it was encrypted.

Related Issue(s)

Fixes #13735

How to test

Release Notes

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@utam0k utam0k requested a review from a team October 13, 2022 04:43
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-to-ca-secret.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 13, 2022
@utam0k utam0k marked this pull request as draft October 13, 2022 05:13
@utam0k
Copy link
Contributor Author

utam0k commented Oct 13, 2022

/werft run

👍 started the job as gitpod-build-to-ca-secret.2
(with .werft/ from main)

@utam0k utam0k marked this pull request as ready for review October 13, 2022 10:51
@Furisto
Copy link
Member

Furisto commented Oct 13, 2022

Workspace is creates successfully. I had problems with the IDE not being displayed but I doubt this has anything to do with this PR and more with the browser not liking self signed certificates.

/hold in case you would like to investigate the IDE issue

@utam0k
Copy link
Contributor Author

utam0k commented Oct 13, 2022

@Furisto I guess you should check the network column of the developer tool you use. I think js and css are blocked.

@kylos101
Copy link
Contributor

👋 @Pothulapati hey there, is this behavior expected / normal? It seems like yes given @Furisto 's description and the browser not liking self signed certificates..

@Pothulapati
Copy link
Contributor

Pothulapati commented Oct 13, 2022

👋 @kylos101 @utam0k

This is not related to the issue, and is about importing the CA into the browser root trust to make it work. This is a required step for IDE to render in the browser. So, We can go ahead now.

@kylos101
Copy link
Contributor

kylos101 commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-to-ca-secret.3
(with .werft/ from main)

@kylos101
Copy link
Contributor

Added ☝️ a job run for integration tests, I expect most will pass, except for perhaps a known flakey one for prebuilds. Should have results in ~45m.

@kylos101
Copy link
Contributor

kylos101 commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-to-ca-secret.4
(with .werft/ from main)

@kylos101
Copy link
Contributor

kylos101 commented Oct 13, 2022

/hold

Integration test job fails with Error: /tmp/installer validate config -c config.yaml exit with non-zero status code.

If we merge "as is", the risk is that it'll break harvester VM preview environment experience for others.

@Furisto
Copy link
Member

Furisto commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true with-clean-slate-deployment=true

👍 started the job as gitpod-build-to-ca-secret.5
(with .werft/ from main)

@Furisto
Copy link
Member

Furisto commented Oct 13, 2022

Fails with Error: error loading config: error unmarshaling JSON: while decoding JSON: json: unknown field "minForUsersOnStripe". I am going to rebase this. Related to #13798

@Furisto
Copy link
Member

Furisto commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true with-clean-slate-deployment=true

👍 started the job as gitpod-build-to-ca-secret.7
(with .werft/ from main)

@Furisto
Copy link
Member

Furisto commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-to-ca-secret.8
(with .werft/ from main)

@kylos101
Copy link
Contributor

@Furisto may want to rebease with main once more, some tests were fixed here.

@Furisto
Copy link
Member

Furisto commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-to-ca-secret.10
(with .werft/ from main)

@kylos101
Copy link
Contributor

kylos101 commented Oct 13, 2022

/werft run with-integration-tests=workspace with-large-vm=true

👍 started the job as gitpod-build-to-ca-secret.11
(with .werft/ from main)

@kylos101
Copy link
Contributor

@kylos101
Copy link
Contributor

/unhold

@roboquat roboquat merged commit 381f347 into main Oct 13, 2022
@roboquat roboquat deleted the to/ca_secret branch October 13, 2022 21:51
@kylos101
Copy link
Contributor

@Pothulapati this is in main now 🙌

@Pothulapati Pothulapati mentioned this pull request Oct 13, 2022
3 tasks
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Oct 19, 2022
@roboquat
Copy link
Contributor

@utam0k: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production do-not-merge/release-note-label-needed size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[self-signed] workspace creation fails in release-2022.09.0
5 participants