-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[supervisor] support multi-line environment variable in ssh #13822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-iqqbot-ssh-bug-in-supervisor-env-13592.5 because the annotations in the pull request description changed |
9ec1405
to
52be29c
Compare
But in Dashboard, it's still one-line input. Will file an issue to track it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's merged = =, sorry, I should /hold without approval to avoid race ( Tide moves faster than before 🐶 |
@aledbf Could you check the code again 🙏 ? And we can make a follow up PR to update if have some |
Description
Before we use
~/.ssh/supervisor_env
to store user envvar in order to export to ssh terminal (it's required by vscode desktop and some user case)But there have some problems with that, it's don't support multi-line environments (some thing like rsa private key...), if you set an environment variable with a multi-line value, you may cannot connection via ssh
This PR remove
~/.ssh/supervisor_env
logic, instead we useSetEnv
argument to support that.Related Issue(s)
Fixes #13592
How to test
gp env
to set a multi-line envenv
andexport
to see multi-line environment variable is workvscode desktop
, it should work same with beforeRelease Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide