Skip to content

[code] build stable code image to bring responsive PortsView #13838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

[code] build stable code image to bring responsive PortsView #13838

merged 1 commit into from
Oct 13, 2022

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 13, 2022 •
edited by loujaybee
Loading

Description

Bring commits to 1.72

Related Issue(s)

Fixes #

How to test

  • Start a workspace in preview env with Latest Code
  • Check if portsView is responsive and Code Browser works basically

Release Notes

Make the VS Code <kbd>PORTS</kbd> view responsive

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-hw-build-ports.1 because the annotations in the pull request description changed
(with .werft/ from main)

@mustard-mh
Copy link
Contributor Author

Works

image

@mustard-mh mustard-mh marked this pull request as ready for review October 13, 2022 12:38
@mustard-mh
Copy link
Contributor Author

@iQQBot Could you approve it?

@mustard-mh mustard-mh requested a review from iQQBot October 13, 2022 12:39
iQQBot
iQQBot approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 7f36420 into main Oct 13, 2022
@roboquat roboquat deleted the hw/build-ports branch October 13, 2022 12:41
@mustard-mh mustard-mh mentioned this pull request Oct 13, 2022
Merged
3 tasks
@filiptronicek filiptronicek added team: IDE deployed Change is completely running in production deployed: IDE IDE change is running in production editor: code (browser) labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note size/XS team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustard-mh @iQQBot @filiptronicek @roboquat