fix(gitpod-cli): ports list safe access to exposed url #14040
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix safe access to
port.Exposed.*
for bothUrl
andVisibility
.Also, I've refactored the existing logic to determine the status, to be more readable and to follow the vscode implementation
Related Issue(s)
Fixes #11990
How to test
gp ports list
and observe nothing is resulted (actually port 3000 is already displayed as non-served by default for some reason)curl lama.sh | sh -s — —port 3001
gp ports list
and observe port 3001 beingopen (private)
gp ports visibility 3001:public
, then rungp ports list
and observe port 3001 being open (public)Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide