Skip to content

content-service: Ignore git hooks when checkout #14067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2022
Merged

content-service: Ignore git hooks when checkout #14067

merged 2 commits into from
Oct 21, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Oct 21, 2022 •
edited by atduarte
Loading

Description

It is not expected that hooks will be executed at checkout, i.e. prebuild, etc.

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/5740

How to test

There are two way to check this PR

  1. Open https://github.com/gitpod-io/gitpod-test-repo/tree/husky and check if not exist output.txt
  2. Run the integration test

Release Notes

Disable git checkout hooks when starting a workspace

Documentation

No

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide

@utam0k utam0k requested a review from a team October 21, 2022 02:50
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-to-git-hooks.11 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Oct 21, 2022
jenting
jenting approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 32e8d1b into main Oct 21, 2022
@roboquat roboquat deleted the to/git-hooks branch October 21, 2022 05:24
@atduarte
Copy link
Contributor

@utam0k updated the release notes, let me know what you think

@utam0k
Copy link
Contributor Author

utam0k commented Oct 27, 2022

@utam0k updated the release notes, let me know what you think

Perfect 💯 Thanks

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utam0k @atduarte @jenting @roboquat