[supervisor] localify struct of ports sort

[mustard-mh]

Description

• Move sort property exists in supervisor only to address Respond PortsStatus with sorted ports #13788 (comment)
• Don't filter not served ports

Related Issue(s)

Fixes #

How to test

• Follow PR Respond PortsStatus with sorted ports #13788
• And check if functions of ports working

Release Notes

NONE

Documentation

Werft options:

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-integration-tests=all
  Valid options are all, workspace, webapp, ide

[werft-gitpod-dev-com]

started the job as gitpod-build-hw-sort-local.1 because the annotations in the pull request description changed
(with .werft/ from main)

[mustard-mh]

/werft run

👍 started the job as gitpod-build-hw-sort-local.2
(with .werft/ from main)

[akosyakov]

Filtering maybe is alright just we need to keep public ports always

[mustard-mh]

It means, port will be gone if user switches a public not served port to private. 🤔

see also #13788 (comment)

[akosyakov]

Ok, let’s keep it.

Another approach it is to filter ports which can be only local, ie nodejs debug ports. But I’m not sure how it can achieved on supervisor level. VS Code extensions certainly know it.

[mustard-mh]

Tested with not served, functions of ports and gp ports commands

[akosyakov]

I removed some ports from .gitpod.yml expecting remaining to be put in front but nothing happened

[akosyakov]

@mustard-mh Did we add unit tests for sorting? Why don't they catch cases when configured ports are changing?

[mustard-mh]

@akosyakov It should work now after the last commit.

cc @iQQBot this fixes the issue you faced

[mustard-mh]

/hold

To squash commits

[mustard-mh]

/werft run

👍 started the job as gitpod-build-hw-sort-local.6
(with .werft/ from main)

[mustard-mh]

To reduce conflict, I created a temp PR #14079 (see its last commit) to remove worksaceConfig in ports.

Conflict i.e. ports (a,b,c) defined in workspace start but removed (a) in instance, a will still be on top of the ports list, this is not correct

We can only respond with ports that exist in the current instance's .gitpod.yml

@akosyakov Is it good for you? then I will cherry-pick it in this PR, squash commits, and mark this PR as ready

[akosyakov]

Don't understand. This PR fixes unnecessary changes to Gitpod protocol? And we fix order with another PR? It is fine with me.

[mustard-mh]

@akosyakov We have watched (.gitpod.yml) config changes in supervisor. config will be parsed into workspaceConfigs, instancePortConfigs and instanceRangeConfigs.

• Our changes in .gitpod.yml will only affect instancePortConfigs and instanceRangeConfigs.
• workspaceConfigs only be parsed from workspace info that comes from server.

That means, if we have a branch, with port 3000 defined in .gitpod.yml, open a workspace and change .gitpod.yml ports to have 8080 only, port 3000 will still be considered as defined in .gitpod.yml and exists on the top on ports list.

So, we can remove everything related to workspaceConfigs because it's already not the current state of the config.

I don't quite sure if you agree with it (remove workspaceConfigs), so I make it another PR, which only adds a commit to remove it compare with the current PR

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.