Add message: Prebuilds have been paused #14081

AlexTugarev · 2022-10-21T11:10:03Z

Description

With this PR we introduce a warning message on the Project overview when it is considered inactive. A Resume prebuilds action allows to trigger a new prebuild on the default branch.

Related Issue(s)

Fixes #9232

How to test

Create a project and start a workspace for it.
Use this statement to set the project inactive
update d_b_project_usage set lastWorkspaceStart = '2021-10-21T13:02:40.674Z';
Check the project page for the warning.
Select the resume action.

Release Notes

Show warning for inactive projects and allow to resume prebuilds again.

Documentation

Werft options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-integration-tests=all
Valid options are all, workspace, webapp, ide

AlexTugarev · 2022-10-21T11:27:54Z

/werft run

👍 started the job as gitpod-build-alex-warn-users-that-prebuilds-9232.1
(with .werft/ from main)

werft-gitpod-dev-com · 2022-10-21T11:58:20Z

started the job as gitpod-build-alex-warn-users-that-prebuilds-9232.3 because the annotations in the pull request description changed
(with .werft/ from main)

components/server/ee/src/workspace/gitpod-server-impl.ts

components/gitpod-protocol/src/teams-projects-protocol.ts

jankeromnes · 2022-10-24T08:05:47Z

Wow, many thanks @AlexTugarev for implementing this! This will be a huge improvement in the UX of "inactive projects".

I'll take a look at this now. 👀

jankeromnes · 2022-10-24T08:10:10Z

components/server/ee/src/workspace/gitpod-server-impl.ts

@@ -2649,6 +2649,11 @@ export class GitpodServerEEImpl extends GitpodServerImpl {

        const context = (await this.contextParser.handle(ctx, user, contextURL)) as CommitContext;

+        // HACK: treat manual triggered prebuild as a reset for the inactivity state


This doesn't seem like a hack to me 👍 (especially if we rename lastWorkspaceStart to something more accurate like lastUserActivity)

Suggested change

// HACK: treat manual triggered prebuild as a reset for the inactivity state

// Treat manual triggered prebuild as a reset for the inactivity state

components/server/src/workspace/gitpod-server-impl.ts

jankeromnes · 2022-10-24T08:28:30Z

Preview env died over the weekend, let's make a new one:

/werft run

👍 started the job as gitpod-build-alex-warn-users-that-prebuilds-9232.5
(with .werft/ from main)

gtsiolis · 2022-10-24T09:55:18Z

Just came here to express some excitement for this seeing 🅰️ this feature happening and 🅱️ the alert component being used once more! ✨

jankeromnes

Many thanks for providing test instructions! The UX works as advertised. ✨ I agree with @gtsiolis that this is super nice to see. 😁

Also, for the future, I wonder if maybe we'll want to show the same warning on other pages as well?

Project Overview	List of Prebuilds	Specific Cancelled Prebuild

Aha, here I see why all my prebuilds get cancelled! 💡	Here, I have no idea why some prebuilds are cancelled 😕	Here, we used to show the exact reason the prebuild got cancelled (e.g. "project is inactive please start a workspace"), but now we only show a very generic "catch all" 😢 why?

jankeromnes · 2022-10-24T12:53:25Z

components/dashboard/src/projects/Project.tsx

+                                            if (project) {
+                                                getGitpodService()
+                                                    .server.triggerPrebuild(project.id, null)
+                                                    .then(() => setIsConsideredInactive(false))


Two possible UX improvements:

When the user clicks, disable the link & show a spinner, so that users know that something is actually happening (i.e. clicking worked) and to prevent them from triggering multiple duplicate prebuilds?

Once the action is successful, auto-redirect to the new prebuild that is in progress? (As opposed to just hiding the warning and otherwise nothing seems to have changed)

@jankeromnes I'm adding below some comments regarding the other pages and future iterations:

Project Overview: I'd keep the alert close to the most relevant page for now, but I agree this could be useful to surface here as this is the project homepage.

List of Prebuilds: I remember being also confused by this, see relevant discussion (internal), Show prebuild failure error message in UI #8637 (Cc @easyCZ), and Improve prebuild status messages including errors on the prebuild page #9111.

Specific Cancelled Prebuild: Makes sense! +1

gtsiolis

Thanks for opening this, @AlexTugarev!

Left one minor comment around copy. 🏓

components/dashboard/src/projects/Project.tsx

jankeromnes

Many thanks @AlexTugarev!

Code looks good, and works (almost) perfectly fine! ✨

/hold due to the nit about setting isResuming to true somewhere

components/dashboard/src/projects/Project.tsx

AlexTugarev · 2022-10-28T10:30:41Z

/hold cancel

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/M labels Oct 21, 2022

AlexTugarev force-pushed the alex/warn-users-that-prebuilds-9232 branch from be2436f to 2f2f5f0 Compare October 21, 2022 11:28

AlexTugarev force-pushed the alex/warn-users-that-prebuilds-9232 branch from 2f2f5f0 to ec4e003 Compare October 21, 2022 13:26

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Oct 21, 2022

AlexTugarev commented Oct 21, 2022

View reviewed changes

components/server/ee/src/workspace/gitpod-server-impl.ts Show resolved Hide resolved

AlexTugarev marked this pull request as ready for review October 21, 2022 13:50

AlexTugarev requested a review from a team October 21, 2022 13:50

roboquat removed the do-not-merge/work-in-progress label Oct 21, 2022

github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 21, 2022

jankeromnes reviewed Oct 24, 2022

View reviewed changes

components/gitpod-protocol/src/teams-projects-protocol.ts Outdated Show resolved Hide resolved

jankeromnes reviewed Oct 24, 2022

View reviewed changes

components/server/src/workspace/gitpod-server-impl.ts Outdated Show resolved Hide resolved

jankeromnes reviewed Oct 24, 2022

View reviewed changes

gtsiolis reviewed Oct 24, 2022

View reviewed changes

components/dashboard/src/projects/Project.tsx Outdated Show resolved Hide resolved

AlexTugarev force-pushed the alex/warn-users-that-prebuilds-9232 branch from ec4e003 to 2dbcc67 Compare October 26, 2022 11:38

AlexTugarev requested a review from jankeromnes October 27, 2022 12:55

jankeromnes approved these changes Oct 27, 2022

View reviewed changes

components/dashboard/src/projects/Project.tsx Show resolved Hide resolved

components/dashboard/src/projects/Project.tsx Outdated Show resolved Hide resolved

roboquat added the do-not-merge/hold label Oct 27, 2022

[projects] add message: Prebuilds have been paused

7d45fa0

AlexTugarev force-pushed the alex/warn-users-that-prebuilds-9232 branch from 2dbcc67 to 7d45fa0 Compare October 28, 2022 10:29

roboquat removed the do-not-merge/hold label Oct 28, 2022

roboquat merged commit f9717b1 into main Oct 28, 2022

roboquat deleted the alex/warn-users-that-prebuilds-9232 branch October 28, 2022 10:38

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Oct 28, 2022

gtsiolis mentioned this pull request Oct 31, 2022

Improve paused prebuilds alert #14294

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add message: Prebuilds have been paused #14081

Add message: Prebuilds have been paused #14081

AlexTugarev commented Oct 21, 2022 •

edited

Loading

AlexTugarev commented Oct 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

werft-gitpod-dev-com bot commented Oct 21, 2022

jankeromnes commented Oct 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes Oct 24, 2022

jankeromnes commented Oct 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 24, 2022 •

edited

Loading

jankeromnes left a comment

jankeromnes Oct 24, 2022 •

edited

Loading

gtsiolis Oct 24, 2022 •

edited

Loading

AlexTugarev Oct 26, 2022

gtsiolis left a comment

jankeromnes left a comment

AlexTugarev commented Oct 28, 2022

		@@ -2649,6 +2649,11 @@ export class GitpodServerEEImpl extends GitpodServerImpl {

		const context = (await this.contextParser.handle(ctx, user, contextURL)) as CommitContext;

		// HACK: treat manual triggered prebuild as a reset for the inactivity state

	// HACK: treat manual triggered prebuild as a reset for the inactivity state
	// Treat manual triggered prebuild as a reset for the inactivity state

Add message: Prebuilds have been paused #14081

Add message: Prebuilds have been paused #14081

Conversation

AlexTugarev commented Oct 21, 2022 • edited Loading

Description

Related Issue(s)

How to test

Release Notes

Documentation

Werft options:

AlexTugarev commented Oct 21, 2022 • edited by werft-gitpod-dev-com bot Loading

werft-gitpod-dev-com bot commented Oct 21, 2022

jankeromnes commented Oct 24, 2022 • edited by werft-gitpod-dev-com bot Loading

jankeromnes Oct 24, 2022

Choose a reason for hiding this comment

jankeromnes commented Oct 24, 2022 • edited by werft-gitpod-dev-com bot Loading

gtsiolis commented Oct 24, 2022 • edited Loading

jankeromnes left a comment

Choose a reason for hiding this comment

jankeromnes Oct 24, 2022 • edited Loading

Choose a reason for hiding this comment

gtsiolis Oct 24, 2022 • edited Loading

Choose a reason for hiding this comment

AlexTugarev Oct 26, 2022

Choose a reason for hiding this comment

gtsiolis left a comment

Choose a reason for hiding this comment

jankeromnes left a comment

Choose a reason for hiding this comment

AlexTugarev commented Oct 28, 2022

AlexTugarev commented Oct 21, 2022 •

edited

Loading

AlexTugarev commented Oct 21, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes commented Oct 24, 2022 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis commented Oct 24, 2022 •

edited

Loading

jankeromnes Oct 24, 2022 •

edited

Loading

gtsiolis Oct 24, 2022 •

edited

Loading