[dashboard] revert Caddy bump #14119
Conversation
|
started the job as gitpod-build-alex-login-window-is-not-closed-14116.1 because the annotations in the pull request description changed |
because of issues with 308 responsed on static assests.
AlexTugarev
force-pushed
the
alex/login-window-is-not-closed-14116
branch
from
1c774b8 to
c54b3bf
Compare
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
The upgrade contained changes to config as well #13276. If we go down the route of this downgrade, shouldn't we revert the config also? |
Came here for this comment. Sadly it's not a simple revert. Note that there were a couple of changes, incl. for dashboard. |
|
@easyCZ, the PR only reverts Caddy the dashboard component, and there the config wasn't touched. See https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/conf/Caddyfile I think, as a follow up we should revert this PR and provide a fixed config. |
@AlexTugarev Can verify on this PR? E.g in previews envs last week, I only had this happen sometimes (maybe older envs). |
I tried a couple of times and never hit it, at least. |
|
@geropl, see the "How to test" for verification.
Basically, without this change the Auth window remains open. |
I know. Was worried about reproducability, but that does not matter. 👍 |
roboquat
added
deployed: webapp
Description
This PR downgrades Caddy for dashboard, due to either an issue with Caddy itself, or with the config written for previous version.
Here is what's happen: requests for static resources get a 308 response unexpectedly, see
Related Issue(s)
Fixes #14116
How to test
Auth popup window should be closed automatically on login/signup.
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide