Skip to content

[JetBrains] Use latest IDE + backend-plugin images in Self-Hosted and Prev Env #14130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Oct 24, 2022

Description

With this PR:

  • prev env will continue to allow testing branch-specific changes of the backend-plugin
  • prev env will use latest images of the JetBrains IDEs
  • SH installations will also use latest images of the JetBrains IDEs

How to test

Already tested ✅
{
      "supervisorImage": "eu.gcr.io/gitpod-core-dev/build/supervisor:commit-96916c5a955b991a94b23aabe5cdbd9fd7881dba",
      "ideOptions": {
        "options": {
          "code": {
            "orderKey": "00",
            "title": "VS Code",
            "type": "browser",
            "logo": "https://ide.example.com/image/ide-logo/vscode.svg",
            "label": "Browser",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/code:commit-96916c5a955b991a94b23aabe5cdbd9fd7881dba",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/code:nightly"
          },
          "code-desktop": {
            "orderKey": "02",
            "title": "VS Code",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/vscode.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/code-desktop:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/code-desktop-insiders:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a"
          },
          "goland": {
            "orderKey": "05",
            "title": "GoLand",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/golandLogo.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/goland:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/goland:latest",
            "pluginImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:commit-313e75e99d5db6f5ac4eb71ecc25b8807fdd8366",
            "pluginLatestImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:latest"
          },
          "intellij": {
            "orderKey": "04",
            "title": "IntelliJ IDEA",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/intellijIdeaLogo.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/intellij:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/intellij:latest",
            "pluginImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:commit-313e75e99d5db6f5ac4eb71ecc25b8807fdd8366",
            "pluginLatestImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:latest"
          },
          "phpstorm": {
            "orderKey": "07",
            "title": "PhpStorm",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/phpstormLogo.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/phpstorm:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/phpstorm:latest",
            "pluginImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:commit-313e75e99d5db6f5ac4eb71ecc25b8807fdd8366",
            "pluginLatestImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:latest"
          },
          "pycharm": {
            "orderKey": "06",
            "title": "PyCharm",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/pycharmLogo.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/pycharm:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/pycharm:latest",
            "pluginImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:commit-313e75e99d5db6f5ac4eb71ecc25b8807fdd8366",
            "pluginLatestImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:latest"
          },
          "rubymine": {
            "orderKey": "08",
            "title": "RubyMine",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/rubymineLogo.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/rubymine:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/rubymine:latest",
            "pluginImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:commit-313e75e99d5db6f5ac4eb71ecc25b8807fdd8366",
            "pluginLatestImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:latest"
          },
          "webstorm": {
            "orderKey": "09",
            "title": "WebStorm",
            "type": "desktop",
            "logo": "https://ide.example.com/image/ide-logo/webstormLogo.svg",
            "image": "eu.gcr.io/gitpod-core-dev/build/ide/webstorm:commit-73ea49bec3ed43432a96d8abb3e2824b7218152a",
            "latestImage": "eu.gcr.io/gitpod-core-dev/build/ide/webstorm:latest",
            "pluginImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:commit-313e75e99d5db6f5ac4eb71ecc25b8807fdd8366",
            "pluginLatestImage": "eu.gcr.io/gitpod-core-dev/build/ide/jb-backend-plugin:latest"
          }
        },
        "defaultIde": "code",
        "defaultDesktopIde": "code-desktop",
        "clients": {
          "jetbrains-gateway": {
            "defaultDesktopIDE": "intellij",
            "desktopIDEs": [
              "intellij",
              "goland",
              "pycharm",
              "phpstorm",
              "rubymine",
              "webstorm"
            ],
            "installationSteps": [
              "If you don't see an open dialog in your browser, make sure you have the \u003ca target='_blank' class='gp-link' href='https://www.gitpod.io/docs/ides-and-editors/jetbrains-gateway#getting-started-jetbrains-gateway'\u003eJetBrains Gateway with Gitpod Plugin\u003c/a\u003e installed on your machine, and then click \u003cb\u003e${OPEN_LINK_LABEL}\u003c/b\u003e below."
            ]
          },
          "vscode": {
            "defaultDesktopIDE": "code-desktop",
            "desktopIDEs": [
              "code-desktop"
            ],
            "installationSteps": [
              "If you don't see an open dialog in your browser, make sure you have \u003ca target='_blank' class='gp-link' href='https://code.visualstudio.com/download'\u003eVS Code\u003c/a\u003e installed on your machine, and then click \u003cb\u003e${OPEN_LINK_LABEL}\u003c/b\u003e below."
            ]
          },
          "vscode-insiders": {
            "defaultDesktopIDE": "code-desktop",
            "desktopIDEs": [
              "code-desktop"
            ],
            "installationSteps": [
              "If you don't see an open dialog in your browser, make sure you have \u003ca target='_blank' class='gp-link' href='https://code.visualstudio.com/insiders'\u003eVS Code Insiders\u003c/a\u003e installed on your machine, and then click \u003cb\u003e${OPEN_LINK_LABEL}\u003c/b\u003e below."
            ]
          }
        }
      }
    }

to test it again, follow:

  1. Start a workspace for this PR: https://gitpod.io/#https://github.com/gitpod-io/gitpod/pull/14130
  2. Run werft run github -a with-preview=1
  3. Install oci-tool by running go install github.com/csweichel/oci-tool@latest
  4. Go to werft and find the image URL for the new installer build (similar to eu.gcr.io/gitpod-core-dev/build/installer:jetbrains-resolve-latest.3 [1])
  5. Run oci-tool, oci-tool fetch file eu.gcr.io/gitpod-core-dev/build/installer:<BUILD_TAG> app/installer
  6. chmod +x installer
  7. ./installer config init
  8. open gitpod.config.yaml and set a random domai (e.g: domain: "example.com")
  9. ./installer render -c /workspace/gitpod/gitpod.config.yaml -> render.yml
  10. gp open render.yml
  11. Observe how the latestImage tag for JetBrains IDE are pointing to actual latest (no commit sha in the URL)
  12. Observe how vdscode latest is still pinned to a specific commit

Release Notes

NONE

@akosyakov
Copy link
Member

It should be for all images, not only jb

@felladrin
Copy link
Contributor

/hold to address the comments above.

@andreafalzetti andreafalzetti force-pushed the jetbrains/resolve-latest branch from 18a141e to 23aa931 Compare October 25, 2022 12:58
@andreafalzetti andreafalzetti force-pushed the jetbrains/resolve-latest branch from 8249fa8 to 4688dd9 Compare October 25, 2022 15:22
@roboquat roboquat added size/M and removed size/S labels Oct 25, 2022
@andreafalzetti andreafalzetti force-pushed the jetbrains/resolve-latest branch 2 times, most recently from 415c165 to 2fc8a73 Compare October 25, 2022 15:50
@roboquat roboquat added size/S and removed size/M labels Oct 25, 2022
@andreafalzetti andreafalzetti marked this pull request as draft October 25, 2022 16:54
@andreafalzetti andreafalzetti force-pushed the jetbrains/resolve-latest branch from 2fc8a73 to d9e1668 Compare October 25, 2022 17:39
@roboquat roboquat added size/M and removed size/S labels Oct 25, 2022
@andreafalzetti andreafalzetti force-pushed the jetbrains/resolve-latest branch 2 times, most recently from 4c9c525 to 71c8a18 Compare October 26, 2022 12:54
@roboquat roboquat added size/S and removed size/M labels Oct 26, 2022
@andreafalzetti andreafalzetti force-pushed the jetbrains/resolve-latest branch from 71c8a18 to 2d36456 Compare October 26, 2022 13:35
@andreafalzetti andreafalzetti marked this pull request as ready for review October 26, 2022 13:37
@iQQBot iQQBot removed the request for review from a team October 26, 2022 14:01
Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreafalzetti
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 71294e1 into main Oct 26, 2022
@roboquat roboquat deleted the jetbrains/resolve-latest branch October 26, 2022 14:06
@andreafalzetti andreafalzetti changed the title [Preview Environment] Use latest jetbrains images [JetBrains] Use latest IDE + backend-plugin images in Self-Hosted and Prev Env Oct 26, 2022
@roboquat roboquat added the deployed: IDE IDE change is running in production label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants