-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[JetBrains] Use latest IDE + backend-plugin images in Self-Hosted and Prev Env #14130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iQQBot
reviewed
Oct 25, 2022
install/installer/pkg/components/ide-service/ide_config_configmap.go
Outdated
Show resolved
Hide resolved
iQQBot
reviewed
Oct 25, 2022
It should be for all images, not only jb |
/hold to address the comments above. |
7cd73b7
to
18a141e
Compare
1 task
felladrin
reviewed
Oct 25, 2022
install/installer/pkg/components/ide-service/ide_config_configmap.go
Outdated
Show resolved
Hide resolved
18a141e
to
23aa931
Compare
8249fa8
to
4688dd9
Compare
415c165
to
2fc8a73
Compare
2fc8a73
to
d9e1668
Compare
4c9c525
to
71c8a18
Compare
71c8a18
to
2d36456
Compare
iQQBot
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR:
backend-plugin
How to test
Already tested ✅
to test it again, follow:
werft run github -a with-preview=1
go install github.com/csweichel/oci-tool@latest
eu.gcr.io/gitpod-core-dev/build/installer:jetbrains-resolve-latest.3
[1])oci-tool fetch file eu.gcr.io/gitpod-core-dev/build/installer:<BUILD_TAG> app/installer
chmod +x installer
./installer config init
gitpod.config.yaml
and set a random domai (e.g:domain: "example.com"
)./installer render -c /workspace/gitpod/gitpod.config.yaml -> render.yml
gp open render.yml
latestImage
tag for JetBrains IDE are pointing to actual latest (no commit sha in the URL)vdscode
latest is still pinned to a specific commitRelease Notes