Skip to content

Use dev/preview:create-preview in Werft #14174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Oct 26, 2022

Description

Use leeway run dev/preview:create-preview in our Werft job.

Related Issue(s)

Fixes https://github.com/gitpod-io/ops/issues/5893

How to test

That it works in Werft (job, preview environment)

werft job run github

That it works in workspaces

leeway run dev/preview:create-preview
leeway run dev/preview:delete-preview

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@mads-hartmann mads-hartmann force-pushed the mads/use-create-preview-in-werft branch from c9a19f9 to d978af1 Compare October 26, 2022 09:20
@gitpod-io gitpod-io deleted a comment from werft-gitpod-dev-com bot Oct 26, 2022
@mads-hartmann mads-hartmann marked this pull request as ready for review October 26, 2022 09:38
@mads-hartmann mads-hartmann requested a review from a team October 26, 2022 09:38
@vulkoingim
Copy link
Contributor

vulkoingim commented Oct 26, 2022

The job you mentioned didn't perform any actions on the VM 👀

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Oct 26, 2022

@vulkoingim haha, was wondering if the reviewer would check! 😝 That's the job that ran after I created the preview from the workspace (was testing that they would not try to make conflicting changes) - didn't bother to delete the preview again just to wait for another Werft job - but let me do that now just to be 100% sure it's fine.

@vulkoingim
Copy link
Contributor

vulkoingim commented Oct 26, 2022

@vulkoingim haha, was wondering if the reviewer would check! 😝 That's the job that ran after I created the preview from the workspace (was testing that they would not try to make conflicting changes) - didn't bother to delete the preview again just to wait for another Werft job - but let me do that now just to be 100% sure it's fine.

Hahah tbh it's one of the rare cases that I did 😄 😄

@mads-hartmann
Copy link
Contributor Author

mads-hartmann commented Oct 26, 2022

@vulkoingim Here's a new job I started using the CLI after having deleted the existing preview env ☺️

@roboquat roboquat merged commit 30fd0a9 into main Oct 26, 2022
@roboquat roboquat deleted the mads/use-create-preview-in-werft branch October 26, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants