Skip to content

[installer] Actually add 'inactivityPeriodForReposInDays' to server configmap #14177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2022
Merged

[installer] Actually add 'inactivityPeriodForReposInDays' to server configmap #14177

merged 4 commits into from
Oct 26, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Oct 26, 2022 •
edited
Loading

Description

Actually add inactivityPeriodForRepos to the server-config ConfigMap in the installer.

Follow-up to #9976 so that we can actually enable this in production.

Related Issue(s)

Fixes #9976

How to test

  1. Should build and pass tests

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@jankeromnes jankeromnes force-pushed the jx/inactive-repos-config branch from 76f6520 to 96c3815 Compare October 26, 2022 08:46
@roboquat roboquat added size/S and removed size/XS labels Oct 26, 2022
@jankeromnes jankeromnes force-pushed the jx/inactive-repos-config branch from 96c3815 to 2ff3043 Compare October 26, 2022 08:53
@jankeromnes jankeromnes force-pushed the jx/inactive-repos-config branch from 2ff3043 to dd16cf1 Compare October 26, 2022 08:59
@jankeromnes jankeromnes marked this pull request as ready for review October 26, 2022 09:49
@jankeromnes jankeromnes requested review from a team October 26, 2022 09:49
@github-actions github-actions bot added team: SID team: webapp Issue belongs to the WebApp team labels Oct 26, 2022
@jankeromnes jankeromnes marked this pull request as draft October 26, 2022 10:05
@roboquat roboquat added size/M and removed size/S labels Oct 26, 2022
@jankeromnes jankeromnes marked this pull request as ready for review October 26, 2022 13:14
@jankeromnes jankeromnes changed the title [installer] Actually add 'inactivityPeriodForRepos' to server configmap [installer] Actually add 'inactivityPeriodForReposInDays' to server configmap Oct 26, 2022
@roboquat roboquat merged commit d7572fd into main Oct 26, 2022
@roboquat roboquat deleted the jx/inactive-repos-config branch October 26, 2022 16:49
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ left review comments

@andrew-farries andrew-farries andrew-farries approved these changes

@ArthurSens ArthurSens ArthurSens approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production release-note-none size/M team: SID team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jankeromnes @easyCZ @andrew-farries @ArthurSens @roboquat