Skip to content

Generate image to to reflect latest upstream changes #14187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Oct 26, 2022

Description

Update code to 1.72.3 (but to the tip of the release branch once again)

How to test

Although I'm a bit skeptical about the need for these tests (only 15 lines have changed), here they are:

  • Switch to VS Code Browser Insiders in settings.
  • Start a workspace.
  • Test the following:
    • terminals are preserved and resized properly between window reloads
    • WebViews are working
    • extension host process: check language smartness and debugging
    • extension management (installing/uninstalling)
    • install the VIM extension to test web extensions
    • that user data is synced across workspaces as well as on workspace restarts, especially for extensions
      • extensions from .gitpod.yml are not installed as sync
      • extensions installed as sync are actually synced to all new workspaces
    • settings should not contain any mentions of MS telemetry
    • WebSockets and workers are properly proxied
      • diff editor should be operatable
      • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old WebSockets are closed and new opened of the same amount
    • workspace specific commands should work, i.e. F1 → type Gitpod prefix
    • that a PR view is preloaded when opening a PR URL
    • test gp open and gp preview
    • test open in VS Code Desktop, check gp open and gp preview in task/user terminals
    • telemetry data is collected in Segment

Release Notes

NONE

Werft options:

  • /werft with-preview
  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ft-update-code-1.72.1 because the annotations in the pull request description changed
(with .werft/ from main)

@filiptronicek
Copy link
Member Author

image

@roboquat roboquat merged commit e80e739 into main Oct 26, 2022
@roboquat roboquat deleted the ft/update-code-1.72 branch October 26, 2022 13:10
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: code (browser) release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants