chore(image-builder-bob): Reduce retry duration #14206
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WVerlaek
commented
Oct 26, 2022
Comment on lines
-509
to
-510
| // ComponentImageBuilder points to the image-builder | ||
| ComponentImageBuilder ComponentType = "image-builder" |
There was a problem hiding this comment.
was unused - refers to the previous image builder component
sagor999
approved these changes
Oct 26, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small improvements for
image-builder-bob's retry logic for connecting to the buildkit daemon:time.Sleepafter last failed retry attempt, should reduce total wait time by ~half if there's an error (due to exponential backoff sleep times).Related Issue(s)
How to test
Follow the README to run
boblocally in a workspace, up to and including trying to build an image. The image build should get stuck inattempting to connect to buildkitd, and quit after 8 attempts (because currently the daemon fails to start in a workspace due to #14003: root user can't write to/workspace).Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide