[server] Add metric for completed image builds #14296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-af-metric-for-server-image-build-completions.11 because the annotations in the pull request description changed |
|
/hold for dependency #14204 |
easyCZ
reviewed
Oct 31, 2022
| @@ -1302,6 +1307,11 @@ export class WorkspaceStarter { | |||
| } | |||
| } | |||
|
|
|||
| // Register a successful image build only if the image actually needed to be built; ie the build was not a no-op. | |||
| if (result.actuallyNeedsBuild) { | |||
There was a problem hiding this comment.
One way to avoid this case would be to export both the started and completed metrics with a label of needed_build. This would still keep it semantic, and would give you the ability to filter these out in the SLO.
easyCZ
approved these changes
Oct 31, 2022
Base automatically changed from
af/fix-server-image-build-total-metric
to
main
November 1, 2022 08:56
Add a counter to track the number of image builds recorded as completed by `server`, broken down by outcome (succeeded, failed).
andrew-farries
force-pushed
the
af/metric-for-server-image-build-completions
branch
from
05e0478 to
371d0c2
Compare
|
started the job as gitpod-build-af-metric-for-server-image-build-completions.13 because the annotations in the pull request description changed |
roboquat
added
deployed: webapp
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a counter for completed image builds
gitpod_server_image_builds_completed_totaltoserverwith dimensions for successful and failed image builds.Increment the relevant counter when an image build succeeds or fails.
Related Issue(s)
Part of #12960
How to test
(tbd once preview envs are working again).
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide