-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[iam] Add proto definitions for OIDC provider config #15149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
reviewed
Dec 5, 2022
This was referenced Dec 5, 2022
easyCZ
reviewed
Dec 5, 2022
easyCZ
reviewed
Dec 5, 2022
easyCZ
reviewed
Dec 5, 2022
8d50099
to
690e3fd
Compare
LGTM. We'll likely iterate on this a bit before we get it just right but current form looks good! |
/werft run 👍 started the job as gitpod-build-at-oidc-proto.2 |
easyCZ
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deployed: IDE
IDE change is running in production
deployed: webapp
Meta team change is running in production
deployed: workspace
Workspace team change is running in production
release-note-none
size/XL
team: IDE
team: SID
team: webapp
Issue belongs to the WebApp team
team: workspace
Issue belongs to the Workspace team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs introduces protocol definitions for OIDC provider configurations.
These configurations are meant to define instances of identity providers. There are no assumptions included about the entities these providers will be associated with.
The configuration surface of OIDC providers included here are to cover use cases like Google initially. Further extensions will be added incrementally if/as required.
Related Issue(s)
Resolves #14951
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh