Skip to content

[oidc] Add stub RPCs #15198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[oidc] Add stub RPCs #15198

merged 1 commit into from
Dec 7, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Dec 6, 2022

Description

Adds stub RPCs for OIDCService.

When the user is part of the experiment, the service returns Unimplemented (for now). Otherwise, it returns Unathorized.

Related Issue(s)

Part of the following:

How to test

unit tests

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested review from a team December 6, 2022 20:41
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Dec 6, 2022
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold as build failed.

@easyCZ easyCZ force-pushed the mp/oidc-stub-rpcs branch from dee2632 to 0415663 Compare December 6, 2022 21:51
@easyCZ
Copy link
Member Author

easyCZ commented Dec 6, 2022

/werft run

👍 started the job as gitpod-build-mp-oidc-stub-rpcs.2
(with .werft/ from main)

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@easyCZ
Copy link
Member Author

easyCZ commented Dec 7, 2022

/unhold

@roboquat roboquat merged commit 114a3bd into main Dec 7, 2022
@roboquat roboquat deleted the mp/oidc-stub-rpcs branch December 7, 2022 08:05
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XL team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants