Skip to content

[installer]: make the kots install overwrite the config if exists #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

[installer]: make the kots install overwrite the config if exists #15263

merged 1 commit into from
Dec 9, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Dec 9, 2022 •
edited
Loading

Description

Reports in Discord of people having issues where the /tmp/gitpod.config.yaml file already exists, meaning the config init fails.

This uses --overwrite to avoid that problem entirely

How to test

Install via KOTS

Release Notes

[installer]: make the kots install overwrite the config if exists

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@mrsimonemms mrsimonemms marked this pull request as ready for review December 9, 2022 09:45
@mrsimonemms mrsimonemms requested a review from a team December 9, 2022 09:45
Pothulapati
Pothulapati approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 407e60f into main Dec 9, 2022
@roboquat roboquat deleted the sje/kots-install-overwrite branch December 9, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pothulapati Pothulapati Pothulapati approved these changes

Assignees
No one assigned
Labels
release-note size/XS team: SID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrsimonemms @Pothulapati @roboquat