Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gha] enable gha build by default #16225

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[gha] enable gha build by default #16225

merged 1 commit into from
Mar 8, 2023

Conversation

vulkoingim
Copy link
Contributor

@vulkoingim vulkoingim commented Feb 6, 2023 •
edited
Loading

Description

Enable GHA by default, with werft as an additional option.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-enable-gha.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-enable-gha.5 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-enable-gha.9 because the annotations in the pull request description changed
(with .werft/ from main)

@vulkoingim vulkoingim marked this pull request as ready for review February 8, 2023 10:14
mads-hartmann
mads-hartmann approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - feel free to merge once you're ready to make the switch 🐎

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-enable-gha.27 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aa-enable-gha.38 because the annotations in the pull request description changed
(with .werft/ from main)

@vulkoingim vulkoingim changed the base branch from main to aa/comment-preview February 24, 2023 14:29
@roboquat roboquat added size/S and removed size/M labels Feb 24, 2023
@vulkoingim vulkoingim changed the title enable gha build by default [gha] enable gha build by default Feb 24, 2023
@vulkoingim vulkoingim force-pushed the aa/comment-preview branch 3 times, most recently from ff73154 to 9746048 Compare March 8, 2023 07:56
Base automatically changed from aa/comment-preview to main March 8, 2023 10:22
@vulkoingim
Copy link
Contributor Author

vulkoingim commented Mar 8, 2023 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-aa-enable-gha.44
(with .werft/ from main)

@roboquat roboquat merged commit 374cda3 into main Mar 8, 2023
@roboquat roboquat deleted the aa/enable-gha branch March 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees
No one assigned
Labels
release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vulkoingim @mads-hartmann @roboquat