Skip to content

allow to redirect only for whitelisted trusted protocols #17559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 10, 2023
Merged

allow to redirect only for whitelisted trusted protocols #17559

merged 3 commits into from
May 10, 2023

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented May 10, 2023 •
edited
Loading

Description

see IDE-69

Related Issue(s)

fix IDE-69

How to test

  • Ensure that VS Code Desktop, VS Code Desktop Insiders and Intellij works

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • analytics=segment
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@akosyakov akosyakov force-pushed the ak/whitelites_protocols branch from d788f0c to 7e62878 Compare May 10, 2023 14:59
@akosyakov akosyakov marked this pull request as ready for review May 10, 2023 14:59
@akosyakov akosyakov requested a review from a team May 10, 2023 14:59
@akosyakov akosyakov requested a review from gtsiolis as a code owner May 10, 2023 14:59
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 10, 2023
@akosyakov
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 24ff8a4 into main May 10, 2023
@roboquat roboquat deleted the ak/whitelites_protocols branch May 10, 2023 19:16
akosyakov added a commit that referenced this pull request May 12, 2023
@akosyakov @filiptronicek
allow to redirect only for whitelisted trusted protocols (#17559)
6771283 
* fix IDE-69: allow to redirect only for whitelisted trusted protocols

* Update components/dashboard/src/service/service.tsx

Co-authored-by: Filip Troníček <[email protected]>

* drop security

---------

Co-authored-by: Filip Troníček <[email protected]>
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 15, 2023
@GoVulnBot GoVulnBot mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek left review comments

@easyCZ easyCZ easyCZ approved these changes

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akosyakov @easyCZ @filiptronicek @roboquat