Skip to content

[proxy] add a liveness check #19531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[proxy] add a liveness check #19531

wants to merge 3 commits into from

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Mar 11, 2024

Description

This is an initial iteration, to setup a liveness check for caddy using the existing /live endpoint on the readiness port. If the problem continues, where new cells sometimes fail the installation because all proxy pods never become ready, we'll want to add a more complex liveness check, perhaps using wait4x, where we check 8003 and 9545 and other ports for "liveness".

E.g.

ProbeHandler: corev1.ProbeHandler{
		Exec: &v1.ExecAction{
			Command: []string{"wait4x", "http", "http://127.0.0.1:9545", "&&", "wait4x", "http", "http://127.0.0.1:8003"},
		},
	},

Reference for the wait4x idea: #8777

Related Issue(s)

Fixes ENG-1889

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@kylos101 kylos101 marked this pull request as ready for review March 11, 2024 19:08
@kylos101 kylos101 requested a review from a team as a code owner March 11, 2024 19:08
@kylos101 kylos101 marked this pull request as draft March 11, 2024 21:43
@gitpod-io gitpod-io deleted a comment from 31031969 Mar 11, 2024
@kylos101 kylos101 closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants