[ws-proxy] prevent podIP being used with many workspaces #20826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/unhold |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue of preventing pod IP addresses from being used across many workspaces by adding IP-based indexing and validation into the WorkspaceInfo provider. Key changes include:
- Adding a new index function for IP addresses.
- Enhancing the WorkspaceInfo lookup logic with IP address conflict checks and warnings.
- Introducing a helper function (workspacesInfoByIPAddress) to retrieve workspaces by IP.
| return nil | ||
| } | ||
|
|
||
| if len(wsInfos) == 1 && wsInfos[0].WorkspaceID != workspaceID { |
There was a problem hiding this comment.
[nitpick] Returning nil when a workspace ID conflict is detected may obscure the underlying issue; consider adding more explicit error handling or detailed documentation to clarify this behavior.
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
kylos101
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[ws-proxy] prevent podIP being used with many workspaces
Related Issue(s)
Fixes CLC-1368
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold