Skip to content

Misc bug fixes for Bitbucket #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Misc bug fixes for Bitbucket #8298

merged 2 commits into from
Feb 24, 2022

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Feb 18, 2022

This PR doesn't add new features.

NONE

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #8298 (d636e03) into main (6497329) will decrease coverage by 20.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8298       +/-   ##
===========================================
- Coverage   31.23%   11.17%   -20.06%     
===========================================
  Files          39       18       -21     
  Lines        5910      993     -4917     
===========================================
- Hits         1846      111     -1735     
+ Misses       3923      880     -3043     
+ Partials      141        2      -139     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-supervisor-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go
components/supervisor/pkg/supervisor/user.go
components/supervisor/pkg/supervisor/services.go
components/supervisor/pkg/ports/served-ports.go
components/supervisor/pkg/config/gitpod-config.go
components/local-app/pkg/auth/auth.go
components/supervisor/pkg/terminal/service.go
components/supervisor/pkg/supervisor/ssh.go
...mponents/supervisor/pkg/supervisor/notification.go
components/supervisor/pkg/ports/ports-config.go
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6497329...d636e03. Read the comment docs.

@AlexTugarev AlexTugarev requested a review from geropl February 24, 2022 08:42
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@roboquat roboquat merged commit ff76959 into main Feb 24, 2022
@roboquat roboquat deleted the at/bitbucket branch February 24, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants