[ts] Update network-facing libs like express (et al.), node-fetch, p-… #8312
Conversation
geropl
force-pushed
the
gpl/update-ts-deps
branch
from
6326304 to
ad966ea
Compare
geropl
force-pushed
the
gpl/update-ts-deps
branch
2 times, most recently
from
b33eef8 to
dc6fb08
Compare
|
/werft run 👍 started the job as gitpod-build-gpl-update-ts-deps.5 🤞 that certs work now |
Codecov Report
@@ Coverage Diff @@
## main #8312 +/- ##
=========================================
+ Coverage 8.42% 11.17% +2.75%
=========================================
Files 33 18 -15
Lines 2339 993 -1346
=========================================
- Hits 197 111 -86
+ Misses 2137 880 -1257
+ Partials 5 2 -3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Finally green - sorry for the noise here. This took a bit longer than expected: We have (by design) divergence how our tests are executed (leeway vs yarn test), and that broke here. |
components/server/package.json
Outdated
| "opentracing": "^0.14.4", | ||
| "p-throttle": "^3.0.0", | ||
| "p-throttle": "^5.0.0", |
There was a problem hiding this comment.
require() of ES Module /app/node_modules/p-throttle/index.js
same issue
There was a problem hiding this comment.
"type": "module" in package.json?
There was a problem hiding this comment.
require() of ES Module /app/node_modules/p-throttle/index.js
same issue
What did you do? And why did the build run? 😬
There was a problem hiding this comment.
server is crashing in the preview deployment
There was a problem hiding this comment.
"type": "module" in package.json?
Not, it's not that easy. Maybe not too complicated either, but I want the other changes to be in by today. I will remove pthrottle, then.
Can you give be your cmdline to reproduce?
geropl
force-pushed
the
gpl/update-ts-deps
branch
from
dc6fb08 to
bd595fa
Compare
…throttle, probot
Description
Besides the update, this PR sets explicit timeouts on all
fetchcalls. Hope this did not cause our increasing lag: firewalls/rate-limiter for gb.xjqchip.workers.devDROPing our packets might very well have caused this behavior. 🙈This took a bit longer than expected: We have (by design) divergence how our tests are executed (leeway vs yarn test), and that broke here.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation