Fixes incorrect podSelectorLabels with workspace #8334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
size/XS
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
iQQBot
commented
Feb 20, 2022
| @@ -19,8 +20,11 @@ import ( | |||
| func networkpolicy(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| labels := common.DefaultLabels(Component) | |||
|
|
|||
| podSelectorLabels := labels | |||
| podSelectorLabels["gitpod.io/networkpolicy"] = "default" | |||
| podSelectorLabels := map[string]string{ | |||
There was a problem hiding this comment.
Separate setting to avoid future failures caused by adding other values to DefaultLabels
Codecov Report
@@ Coverage Diff @@
## main #8334 +/- ##
==========================================
- Coverage 33.00% 7.60% -25.41%
==========================================
Files 33 31 -2
Lines 4735 2171 -2564
==========================================
- Hits 1563 165 -1398
+ Misses 3054 2003 -1051
+ Partials 118 3 -115
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Works well, thank you @iQQBot ! gitpod /workspace/gitpod (pd/fix-network-policy) $ kubectl describe pod ws-3c81f5ae-bacb-4622-a890-da712c4d8313
Name: ws-3c81f5ae-bacb-4622-a890-da712c4d8313
Namespace: staging-pd-fix-network-policy
Priority: 0
Node: a-node
Start Time: Sun, 20 Feb 2022 14:51:01 +0000
Labels: app=gitpod
component=workspace
gitpod.io/networkpolicy=default
gpwsman=true
headless=false
metaID=gitpodio-templatepythonf-sl7n6agbfjl
owner=47d8709c-9e0b-4a87-9c17-2d6b4a6af52a
workspaceID=3c81f5ae-bacb-4622-a890-da712c4d8313
workspaceType=regular |
kylos101
approved these changes
Feb 20, 2022
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect podSelectorLabels with workspace
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation