Skip to content

[ws-manager] fix incorrect status when image pull is done #8335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Feb 21, 2022

Description

[ws-manager] fix incorrect status when image pull is done
If pod is running, the workspace status should be change to initializing

Related Issue(s)

Fixes #8323

How to test

  1. create a workspace
  2. write a big file using dd
  3. stop workspace
  4. restart this workspace
  5. you will see the most time cost is initializing instead of pulling image

Release Notes

NONE

Documentation

@iQQBot iQQBot requested a review from a team February 21, 2022 02:17
@github-actions github-actions bot added team: workspace Issue belongs to the Workspace team and removed size/XS labels Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #8335 (d056d6a) into main (8ab2f28) will increase coverage by 21.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8335       +/-   ##
===========================================
+ Coverage   12.31%   33.40%   +21.08%     
===========================================
  Files          20       31       +11     
  Lines        1161     4559     +3398     
===========================================
+ Hits          143     1523     +1380     
- Misses       1014     2920     +1906     
- Partials        4      116      +112     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app 39.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/status.go 74.58% <ø> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-manager/pkg/clock/clock.go 68.62% <0.00%> (ø)
...-manager/pkg/manager/internal/workpool/workpool.go 100.00% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 83.17% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 20.81% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab2f28...d056d6a. Read the comment docs.

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense. It's mostly a left-over from the days when content init wasn't tied to container readiness.

Great find!

@roboquat roboquat merged commit 85cda2b into main Feb 21, 2022
@roboquat roboquat deleted the pd/fix-error-status branch February 21, 2022 08:41
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulling container image message but actually installing vscode extensions
3 participants