Skip to content

Move installer to /install #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2022
Merged

Move installer to /install #8345

merged 2 commits into from
Feb 22, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Feb 21, 2022 •
edited
Loading

Description

Move the installer to /install. This directory will be used for installation resources (including the KOTS specification)

How to test

cd install/installer
go run .

Release Notes

NONE

Documentation

@roboquat roboquat added size/XS and removed size/M labels Feb 21, 2022
@roboquat roboquat added size/M and removed size/XS labels Feb 21, 2022
@mrsimonemms mrsimonemms force-pushed the sje/kots branch 2 times, most recently from 3575042 to e51e9d8 Compare February 21, 2022 13:31
@mrsimonemms mrsimonemms force-pushed the sje/kots branch 2 times, most recently from 5336ce6 to b45b3b5 Compare February 21, 2022 13:43
@codecov
Copy link

codecov bot commented Feb 21, 2022 •
edited
Loading

Codecov Report

Merging #8345 (d0d4017) into main (4d48ccb) will decrease coverage by 26.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #8345       +/-   ##
==========================================
- Coverage   34.21%   7.59%   -26.62%     
==========================================
  Files          57      31       -26     
  Lines        7929    2172     -5757     
==========================================
- Hits         2713     165     -2548     
+ Misses       5016    2004     -3012     
+ Partials      200       3      -197
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-image-builder-mk3-app ?
components-installer-raw-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-api-go-lib ?
components-ws-manager-app ?
components-ws-proxy-app ?
dev-loadgen-app ?
install-installer-raw-app 4.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/ca.go 0.00% <ø> (ø)
install/installer/pkg/common/common.go 4.43% <ø> (ø)
install/installer/pkg/common/display.go 0.00% <ø> (ø)
install/installer/pkg/common/objects.go 0.00% <ø> (ø)
install/installer/pkg/common/render.go 0.00% <ø> (ø)
install/installer/pkg/common/storage.go 0.00% <ø> (ø)
...l/installer/pkg/components/ws-manager/configmap.go 24.22% <ø> (ø)
.../installer/pkg/components/ws-manager/deployment.go 0.00% <ø> (ø)
...staller/pkg/components/ws-manager/networkpolicy.go 0.00% <ø> (ø)
...nstall/installer/pkg/components/ws-manager/role.go 0.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d48ccb...d0d4017. Read the comment docs.

@mrsimonemms mrsimonemms changed the title WIP: Add KOTS support for installer Move installer to /install Feb 21, 2022
@mrsimonemms mrsimonemms marked this pull request as ready for review February 21, 2022 13:49
@mrsimonemms mrsimonemms requested review from a team February 21, 2022 13:49
@github-actions github-actions bot added team: IDE team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Feb 21, 2022
@mrsimonemms
Copy link
Contributor Author

Have made the .github/CODEOWNERS change. It's now the same as the other move now

mustard-mh
mustard-mh previously approved these changes Feb 22, 2022
View reviewed changes
JanKoehnlein
JanKoehnlein previously approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

princerachit
princerachit previously approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@princerachit princerachit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflict

@mrsimonemms
Copy link
Contributor Author

Conflicts resolved.

@mrsimonemms mrsimonemms requested review from a team February 22, 2022 11:22
@roboquat roboquat merged commit 4820e80 into main Feb 22, 2022
@roboquat roboquat deleted the sje/kots branch February 22, 2022 11:33
@corneliusludmann corneliusludmann mentioned this pull request Feb 22, 2022
Merged
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

@mustard-mh mustard-mh mustard-mh approved these changes

@corneliusludmann corneliusludmann corneliusludmann approved these changes

@princerachit princerachit princerachit approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: delivery Issue belongs to the self-hosted team team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mrsimonemms @iQQBot @corneliusludmann @mustard-mh @JanKoehnlein @princerachit @roboquat