Skip to content

werft/jobs/build: Add observability support to installer #8358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

ArthurSens
Copy link
Contributor

Signed-off-by: ArthurSens [email protected]

Description

It is now possible to have observability set up using the installer in core-dev

Related Issue(s)

Fixes #8193

How to test

Run

werft run github -a with-observability

You should see monitoring-satellite running in the preview.
Traces should be present in Honeycomb

Release Notes

NONE

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #8358 (105d746) into main (e2d8e2d) will increase coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8358      +/-   ##
=========================================
+ Coverage   8.42%   11.17%   +2.75%     
=========================================
  Files         33       18      -15     
  Lines       2339      993    -1346     
=========================================
- Hits         197      111      -86     
+ Misses      2137      880    -1257     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-installer-raw-app ?
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../installer/pkg/components/ws-manager/deployment.go
components/installer/pkg/common/objects.go
...staller/pkg/components/ws-manager/networkpolicy.go
...installer/pkg/components/ws-manager/rolebinding.go
...components/ws-manager/unpriviledged-rolebinding.go
...s/installer/pkg/components/ws-manager/tlssecret.go
...onents/installer/pkg/components/ws-manager/role.go
components/local-app/pkg/auth/auth.go
...s/installer/pkg/components/ws-manager/configmap.go
components/installer/pkg/common/display.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d8e2d...105d746. Read the comment docs.

@roboquat roboquat merged commit 244b40f into main Feb 22, 2022
@roboquat roboquat deleted the as/installer-obs branch February 22, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[preview environment] Support combination of: with-observability + installer
3 participants