Skip to content

Fix VM image ID #8362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fix VM image ID #8362

merged 1 commit into from
Feb 21, 2022

Conversation

meysholdt
Copy link
Member

Description

Follow-up PR to #8357. The image-ID of the VM image must be adjusted in another location.

Related Issue(s)

Fixes #

How to test

run /werft run with-vm=true and confirm that the preview env is coming up.

Release Notes

NONE

Documentation

@meysholdt
Copy link
Member Author

meysholdt commented Feb 21, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-me-fiximage.1

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #8362 (ebdfeb5) into main (3f05d6f) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8362      +/-   ##
==========================================
- Coverage   12.31%   11.17%   -1.14%     
==========================================
  Files          20       18       -2     
  Lines        1161      993     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1014      880     -134     
+ Partials        4        2       -2     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f05d6f...ebdfeb5. Read the comment docs.

@meysholdt
Copy link
Member Author

meysholdt commented Feb 21, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-me-fiximage.2

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the hold label as it looks like you're still testing (from the werft trigger comment) but the code changes look good so feel free to remove the label :)

@meysholdt
Copy link
Member Author

meysholdt commented Feb 21, 2022

/werft run with-vm=true

👍 started the job as gitpod-build-me-fiximage.3

@meysholdt
Copy link
Member Author

meysholdt commented Feb 21, 2022

/werft run no-preview=true

👍 started the job as gitpod-build-me-fiximage.4

@roboquat roboquat merged commit 7ccac75 into main Feb 21, 2022
@roboquat roboquat deleted the me/fiximage branch February 21, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants