-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix VM image ID #8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VM image ID #8362
Conversation
/werft run with-vm=true 👍 started the job as gitpod-build-me-fiximage.1 |
Codecov Report
@@ Coverage Diff @@
## main #8362 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/werft run with-vm=true 👍 started the job as gitpod-build-me-fiximage.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the hold label as it looks like you're still testing (from the werft trigger comment) but the code changes look good so feel free to remove the label :)
/werft run with-vm=true 👍 started the job as gitpod-build-me-fiximage.3 |
/werft run no-preview=true 👍 started the job as gitpod-build-me-fiximage.4 |
Description
Follow-up PR to #8357. The image-ID of the VM image must be adjusted in another location.
Related Issue(s)
Fixes #
How to test
run
/werft run with-vm=true
and confirm that the preview env is coming up.Release Notes
Documentation