Remove ghost from the codebase #8363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: IDE
team: devx
team: webapp
github-actions
bot
added
team: IDE
team: devx
team: webapp
aledbf
force-pushed
the
aledbf/ghosts
branch
2 times, most recently
from
6fa4ce2 to
0b6a68b
Compare
github-actions
bot
added
the
team: delivery
Codecov Report
@@ Coverage Diff @@
## main #8363 +/- ##
==========================================
+ Coverage 8.41% 27.42% +19.00%
==========================================
Files 33 44 +11
Lines 2340 5733 +3393
==========================================
+ Hits 197 1572 +1375
- Misses 2138 4044 +1906
- Partials 5 117 +112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * Copyright (c) 2021 Gitpod GmbH. All rights reserved. | |||
| * Copyright (c) 2022 Gitpod GmbH. All rights reserved. | |||
There was a problem hiding this comment.
I was under the impression we shouldn't update these (ref)
There was a problem hiding this comment.
💯 ☝️ But this is a generated file, so not sure it is relevant. 🤷
|
Everything looks good, would like to get info on @mads-hartmann 's question and did we test this with helm ? |
aledbf
force-pushed
the
aledbf/ghosts
branch
from
0b6a68b to
d0f8ca4
Compare
mads-hartmann
previously approved these changes
Feb 22, 2022
There was a problem hiding this comment.
LGTM 🚀 The only outstanding comment is about the copyright header update, but sounds like it's an autogenerated so might not be relevant (comment reference)
aledbf
force-pushed
the
aledbf/ghosts
branch
from
d0f8ca4 to
9316b22
Compare
mads-hartmann
previously approved these changes
Feb 23, 2022
aledbf
force-pushed
the
aledbf/ghosts
branch
from
9316b22 to
b4eec49
Compare
mrsimonemms
approved these changes
Feb 23, 2022
geropl
approved these changes
Feb 24, 2022
mads-hartmann
approved these changes
Feb 24, 2022
|
Should we clean these up too?
|
mustard-mh
approved these changes
Feb 25, 2022
csweichel
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that
ws-schedulerwas removed and we are not using ghost workplaces anymore, remove itHow to test
Release Notes
Documentation