-
Notifications
You must be signed in to change notification settings - Fork 1.3k
dashboard: set correct default setting for telemetry #8373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8373 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@Pothulapati Could you rebase and squash this? |
6764e7a
to
7829016
Compare
@corneliusludmann Done! (Also, Did a mental reminder to myself to always amend commits instead) |
Yeah! 🚀 Thanks! 🙏 |
@Pothulapati Are you sure the rebase on main was successful? I'm missing this change: #8386 🤔 |
Fixes #8344 `Enable Service Ping` seems to be set to `false` by defaut until the UI is re-loaded. This fixes it by also adding the retrieval logic into `useEffect` thereby calling it everytime, even during initial render. Signed-off-by: Tarun Pothulapati <[email protected]>
7829016
to
9d89553
Compare
@corneliusludmann Now, It's up! 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change looks good to me.
Description
Enable Service Ping
seems to be set tofalse
by defaut untilthe UI is re-loaded. This fixes it by also adding the retrieval
logic into
useEffect
thereby calling it everytime, even duringinitial render.
Signed-off-by: Tarun Pothulapati [email protected]
Related Issue(s)
Fixes #8344
How to test
Open the
admin/settings
dashboard, and check if its set totrue
by default without a refresh.Release Notes
Documentation