Skip to content

Pre-populate Cmd+O modal and sort suggested context URLs by most-recently-used first #8380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Feb 22, 2022

Description

This change "brings back" recent repositories:

  • Pre-populate Cmd+O modal with unfiltered suggestions
  • Sort suggestions by most-recently-used first

Related Issue(s)

Addresses the first part of #8088:

  1. Recover behavior to show recents by default
    • Autopopulate results even when input is empty
    • Tweak result ranking to show recents first
    • Remove current help text
    • Set placeholder = “Paste repository URL or type for suggestions”

How to test

Release Notes

Pre-populate Cmd+O modal and sort suggested context URLs by most-recently-used first

Documentation

@jankeromnes jankeromnes requested a review from a team February 22, 2022 11:30
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team and removed size/M labels Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #8380 (bd231e1) into main (4d48ccb) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8380      +/-   ##
==========================================
+ Coverage   34.21%   34.39%   +0.18%     
==========================================
  Files          57       52       -5     
  Lines        7929     6893    -1036     
==========================================
- Hits         2713     2371     -342     
+ Misses       5016     4354     -662     
+ Partials      200      168      -32     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-image-builder-mk3-app ?
components-installer-raw-app 4.58% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-api-go-lib ?
components-ws-manager-app 39.66% <ø> (ø)
components-ws-proxy-app 68.63% <ø> (ø)
dev-loadgen-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
...ents/image-builder-mk3/pkg/orchestrator/monitor.go
...image-builder-mk3/pkg/orchestrator/orchestrator.go
...ents/image-builder-mk3/pkg/orchestrator/metrics.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d48ccb...bd231e1. Read the comment docs.

Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit ddc80c1 into main Feb 22, 2022
@roboquat roboquat deleted the jx/improve-modal branch February 22, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants