Skip to content

jb: auto preconfigure module SDK as well #8415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,72 @@

package io.gitpod.jetbrains.remote

import com.intellij.ProjectTopics
import com.intellij.openapi.diagnostic.thisLogger
import com.intellij.openapi.module.Module
import com.intellij.openapi.module.ModuleManager
import com.intellij.openapi.project.ModuleListener
import com.intellij.openapi.project.Project
import com.intellij.openapi.projectRoots.ProjectJdkTable
import com.intellij.openapi.projectRoots.Sdk
import com.intellij.openapi.roots.ModuleRootManager
import com.intellij.openapi.roots.ModuleRootModificationUtil
import com.intellij.openapi.roots.ProjectRootManager
import com.intellij.util.application
import kotlinx.coroutines.GlobalScope
import kotlinx.coroutines.future.await
import kotlinx.coroutines.launch
import java.util.concurrent.CompletableFuture


class GitpodProjectManager(
private val project: Project
) {

/**
* It is a workaround for https://youtrack.jetbrains.com/issue/GTW-88
*/
init {
val pendingSdk = CompletableFuture<Sdk>()
application.invokeLaterOnWriteThread {
application.runWriteAction {
configureSdk()
try {
ProjectJdkTable.getInstance().preconfigure()
pendingSdk.complete(ProjectJdkTable.getInstance().allJdks.firstOrNull())
} catch (t: Throwable) {
pendingSdk.completeExceptionally(t)
}
}
}
GlobalScope.launch {
val sdk = pendingSdk.await() ?: return@launch
thisLogger().warn("gitpod: '${project.name}' project: SDK detected: $sdk")
project.messageBus.connect().subscribe(ProjectTopics.MODULES, object : ModuleListener {
override fun moduleAdded(project: Project, module: Module) {
configureSdk(sdk)
}
})
configureSdk(sdk)
}
}

/**
* It is a workaround for https://youtrack.jetbrains.com/issue/GTW-88
*/
private fun configureSdk() {
ProjectJdkTable.getInstance().preconfigure()
val sdk = ProjectJdkTable.getInstance().allJdks.firstOrNull() ?: return
val projectRootManager = ProjectRootManager.getInstance(project)
if (projectRootManager.projectSdk != null) {
return
private fun configureSdk(sdk: Sdk) {
application.invokeLaterOnWriteThread {
application.runWriteAction {
val projectRootManager = ProjectRootManager.getInstance(project)
if (projectRootManager.projectSdk == null) {
projectRootManager.projectSdk = sdk
thisLogger().warn("gitpod: '${project.name}' project: SDK was auto preconfigured: $sdk")
}
}
}
for (module in ModuleManager.getInstance(project).modules) {
ModuleRootModificationUtil.updateModel(module) { m ->
if (m.sdk == null) {
m.sdk = sdk
thisLogger().warn("gitpod: '${module.name}' module: SDK was auto preconfigured: $sdk")
}
}
}
projectRootManager.projectSdk = sdk
thisLogger().warn("gitpod: SDK was auto preconfigured: $sdk")
}
}