Skip to content

supplement git credential-helper smoke test comment #8443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Feb 24, 2022

Description

supplement git credential-helper smoke test comment

Related Issue(s)

Fixes #

How to test

NO NEED TEST

Release Notes

NONE

Documentation

/werft no-preview

@iQQBot iQQBot requested a review from a team February 24, 2022 16:56
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #8443 (833c6fa) into main (6afc7f2) will increase coverage by 2.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8443      +/-   ##
=========================================
+ Coverage   8.41%   11.17%   +2.75%     
=========================================
  Files         33       18      -15     
  Lines       2340      993    -1347     
=========================================
- Hits         197      111      -86     
+ Misses      2138      880    -1258     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/credential-helper.go 6.66% <ø> (ø)
install/installer/pkg/common/storage.go
install/installer/pkg/common/display.go
...l/installer/pkg/components/ws-manager/configmap.go
...installer/pkg/components/ws-manager/rolebinding.go
...nstall/installer/pkg/components/ws-manager/role.go
...l/installer/pkg/components/ws-manager/tlssecret.go
...staller/pkg/components/ws-manager/networkpolicy.go
install/installer/pkg/common/render.go
.../installer/pkg/components/ws-manager/deployment.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6afc7f2...833c6fa. Read the comment docs.

Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@roboquat roboquat merged commit 836aca6 into main Feb 24, 2022
@roboquat roboquat deleted the pd/credential-8408-1 branch February 24, 2022 18:56
@Furisto Furisto restored the pd/credential-8408-1 branch February 25, 2022 14:36
@iQQBot iQQBot deleted the pd/credential-8408-1 branch February 27, 2022 17:24
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none size/XS team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants