try harder when attempting to add or remove annotation from workspaces #8519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In GCP logs I observed this error pop up quite often:
cannot workspace: cannot mark workspace redacted with -gitpod/never-ready: Operation cannot be fulfilled on pods "ws-redacted": the object has been modified; please apply your changes to the latest version and try again
https://cloudlogging.app.goo.gl/d9NjYg6x9NgPfumeA
This is caused by default backoff being too short and after 4 attempts to update pod with updated annotation, it fails and marks whole workspace as failed.
So instead this PR make it try harder.
Related Issue(s)
Fixes #
How to test
There is no easy way to test this, as it happens when some other process updates pod while we are trying to call markWorkspace function.
Release Notes
Documentation