Skip to content

Set the timeout for the server deployment to 10min #8530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

fullmetalrooster
Copy link
Contributor

@fullmetalrooster fullmetalrooster commented Mar 2, 2022

Description

Installing Gitpod in a VM on Harvester lead to a timeout during the server deployment. Using twice the time should prevent the deployment from failing.

Related Issue(s)

Fixes #

How to test

Create a new VM using werft.

Release Notes

None

Documentation

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8530 (e55f2b7) into main (61b50e7) will increase coverage by 2.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            main    #8530      +/-   ##
=========================================
+ Coverage   8.37%   11.17%   +2.79%     
=========================================
  Files         33       18      -15     
  Lines       2339      993    -1346     
=========================================
- Hits         196      111      -85     
+ Misses      2138      880    -1258     
+ Partials       5        2       -3     
Flag Coverage Δ
components-gitpod-cli-app 11.17% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
install-installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
install/installer/pkg/common/storage.go
.../installer/pkg/components/ws-manager/deployment.go
install/installer/pkg/common/ca.go
install/installer/pkg/common/common.go
install/installer/pkg/common/render.go
...staller/pkg/components/ws-manager/networkpolicy.go
install/installer/pkg/common/objects.go
components/local-app/pkg/auth/auth.go
...l/installer/pkg/components/ws-manager/tlssecret.go
components/local-app/pkg/auth/pkce.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b50e7...e55f2b7. Read the comment docs.

Copy link
Contributor

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout we're experiencing is when checking the rollout of server (the gitpod component), and not when starting the VM 😅

This happens during the werft phase "monitor server deployment". Could you change this PR to extend the timeout of this line?

@fullmetalrooster fullmetalrooster changed the title Set the timeout for new VMs to 20 min Set the timeout for the server deployment to 10min Mar 2, 2022
@roboquat roboquat merged commit c1c3955 into main Mar 2, 2022
@roboquat roboquat deleted the wth/set-timeout branch March 2, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants